Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv: move batch client code to file client_batch.go (#11108) #11228

Merged
merged 4 commits into from
Jul 15, 2019
Merged

store/tikv: move batch client code to file client_batch.go (#11108) #11228

merged 4 commits into from
Jul 15, 2019

Conversation

tiancaiamao
Copy link
Contributor

Cherry-pick #11108

@tiancaiamao tiancaiamao added type/3.0 cherry-pick component/tikv type/enhancement The issue or PR belongs to an enhancement. labels Jul 12, 2019
@tiancaiamao
Copy link
Contributor Author

PTAL @lysu @hicqu

lysu
lysu reviewed Jul 12, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Jul 12, 2019

/run-all-tests

jackysp
jackysp approved these changes Jul 12, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2. labels Jul 15, 2019
@kennytm
Copy link
Contributor

kennytm commented Jul 15, 2019

/run-all-tests

@zz-jason zz-jason merged commit 754816e into pingcap:release-3.0 Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
component/tikv priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiancaiamao @jackysp @kennytm @lysu @zz-jason