evaluator, parser: support UTC_DATE() #1045
Conversation
|
@overvenus Thanks for your report! We will add more builtin functions. |
|
@shenli Hi, and yes, I have just added a new builtin function, it is a PR not issue. Maybe I should change title to Add UTC_DATE()? |
|
Sorry.... It is my mistake. |
| @@ -316,6 +316,14 @@ func (s *testEvaluatorSuite) TestCurrentTime(c *C) { | |||
| c.Assert(err, NotNil) | |||
| } | |||
|
|
|||
| func (s *testEvaluatorSuite) TestUTCDate(c *C) { | |||
There was a problem hiding this comment.
Can you add another case like:
mysql> select utc_date + 1;
+--------------+
| utc_date + 1 |
+--------------+
| 20160402 |
+--------------+
There was a problem hiding this comment.
ok, I will take a look, and maybe modification of current_date() is also needed.
|
@coocood @qiuyesuifeng PTAL |
|
@overvenus Any update for this PR? |
overvenus
force-pushed
the
builtin-time-utc
branch
from
440446b to
1e5ef42
Compare
|
@shenli @qiuyesuifeng PTAL |
|
LGTM |
|
@overvenus Thanks. |
see issue: pingcap#236.
overvenus
force-pushed
the
builtin-time-utc
branch
from
1e5ef42 to
f70e1d4
Compare
|
Squashed. @shenli @qiuyesuifeng cc @c4pt0r |
| @@ -390,6 +390,16 @@ func builtinCurrentTime(args []types.Datum, _ context.Context) (d types.Datum, e | |||
| return convertToDuration(d, fsp) | |||
| } | |||
|
|
|||
| // See https://dev.mysql.com/doc/refman/5.7/en/date-and-time-functions.html#function_utc-date | |||
| func builtinUTCDate(args []types.Datum, _ context.Context) (d types.Datum, err error) { | |||
| year, month, day := time.Now().Date() | |||
There was a problem hiding this comment.
Maybe we should change this to time.Now().UTC().Date()?
There was a problem hiding this comment.
Oops, I'm sorry, you are right, thank you for pointing out, I will fix it tomorrow.
|
PTAL |
|
LGTM |
see issue: #236.