util/types: support convert year #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert support more types
| @@ -138,6 +138,23 @@ func Convert(val interface{}, target *FieldType) (v interface{}, err error) { // | |||
| } | |||
| // TODO: check Flen | |||
| return x, nil | |||
| case mysql.TypeYear: | |||
| var intVal int64 | |||
There was a problem hiding this comment.
how about
var (
intVal int64
err error
)
|
There is no year support in mysql cast function? why to support this? |
|
Convert can be used to replace column.CastValue later. |
| switch x := val.(type) { | ||
| case string: | ||
| intVal, err = StrToInt(x) | ||
| default: |
There was a problem hiding this comment.
mysql> insert into t select cast("2015-11-11 11:11:11" as datetime);
Query OK, 1 row affected (0.01 sec)
Records: 1 Duplicates: 0 Warnings: 0
I think you should support time type separately. ToInt64 will not work for time type.
| switch x := val.(type) { | ||
| case string: | ||
| intVal, err = StrToInt(x) | ||
| case mysql.Time: |
There was a problem hiding this comment.
mysql.Duration will use current year.
coocood
added a commit
that referenced
this pull request
Sep 6, 2015
util/types: support convert year
spongedu
pushed a commit
to spongedu/tidb
that referenced
this pull request
Oct 17, 2019
ichn-hu
pushed a commit
to ichn-hu/tidb
that referenced
this pull request
May 10, 2020
* merge master * fix bug * fix bug * fix ut
ti-srebot
pushed a commit
that referenced
this pull request
Jul 27, 2020
* support batch cop for tiflash * support batch cop * support join push down to tiflash * refine * change pb * push join * fix * add hint * refine hint * add ranges * fix * fix * fix push down * fix index * enable distsql for join * add a session var to disable/enable broadcast join * fix bug * fix bug * tiny fix * enable cast decimal pushdown to tiflash * fix * fix bc join bug * make broadcast plan stable * refine code * fix bug * basic support for multi table broadcast join * fix bug * basic cbo for broadcast join * improve * fix bug * remote useless code * add tests * pass unit tests * refine code * support execute summary info for broadcast join * fix bug in explain for broadcast join * format code * remove un-needed code * fix make dev * address comments * Hanfei/join merge (#7) * enable exec details for batch cop * format code * fix test * change tidb_opt_broadcast_join to global vars * Ban cartesian join to be pushed down to TiFlash (#8) * merge master (#10) * merge master * fix bug * fix bug * fix ut * check session var conflict * Add perfer local hint for broadcast join (#12) * update * remove useless code * remove useless code * update parser * add test for prefer local join * use bcj_local * update go.mod * refine planner * refine comments * fix make dev * fix make dev * update parser * address comments * fix make dev * disable broadcast join when new collation is enabled * Update planner/core/exhaust_physical_plans.go Co-authored-by: Zhuomin(Charming) Liu <[email protected]> * address comments * fix * address comments * fix tests * address comments Co-authored-by: xufei <[email protected]> Co-authored-by: xufei <[email protected]> Co-authored-by: 虎 <[email protected]> Co-authored-by: Zhuomin(Charming) Liu <[email protected]>
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
add concurrency arg
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
* mysql: Add NO_AUTO_CREATE_USER detection
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
* mysql: Add NO_AUTO_CREATE_USER detection
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
* mysql: Add NO_AUTO_CREATE_USER detection
rebelice
pushed a commit
to rebelice/tidb
that referenced
this pull request
Jan 6, 2022
remove debug info
lichunzhu
added a commit
to lichunzhu/tidb
that referenced
this pull request
Jan 7, 2022
add fprof to check performance problem
AilinKid
added a commit
to AilinKid/tidb
that referenced
this pull request
Mar 15, 2022
ywqzzy
pushed a commit
to ywqzzy/tidb
that referenced
this pull request
Jun 29, 2023
fix writer append rows
guoshouyan
pushed a commit
to guoshouyan/tidb
that referenced
this pull request
Mar 5, 2024
Co-authored-by: artem_danilov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert support more types