-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement aggregate functions under the new framework #6952
Comments
I'm interested to rewrite |
Really thank you for your support. @Xuanwo |
@XuHuaiyu OK, I will implement |
I want to implement SUM.OK? |
@laidahe Sure, thanks for your participation!😁 |
hi, @laidahe friendly ping ^_^ |
All the aggregate functions are implemented, close this issue now. |
This PR #6852 introduced the new framework to execute aggregate functions. Now the rest work is to rewrite every aggregate function under this new framework. The aggregate functions need to rewrite are listed in executor/aggfuncs/builder.go, which are:
COUNT
@XuanwoSUM
@laidaheAVG
@zz-jason aggfuncs: partially implement "AVG" #6951FIRSTROW
@XuHuaiyuMAX
@XuHuaiyuMIN
@XuHuaiyuGROUP_CONCAT
@XuHuaiyuBIT_OR
@crazycs520BIT_XOR
@XuHuaiyuBIT_AND
@XuHuaiyuTo rewrite a function, take #6951 as an example, you need to:
buildXXX()
function for the corresponding aggregate function in executor/aggfuncs/builder.govar
code block in file executor/aggfuncs/aggfuncs.go for code navigation.If you are going to rewrite one of the above aggregate functions, please firstly make a comment here to let other contributors know. Feel free to contribute 😁
The text was updated successfully, but these errors were encountered: