Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: returned error fromloadTime() when make dev #6892

Closed
zhexuany opened this issue Jun 24, 2018 · 5 comments
Closed

store: returned error fromloadTime() when make dev #6892

zhexuany opened this issue Jun 24, 2018 · 5 comments
Assignees
Labels
sig/transaction SIG:Transaction

Comments

@zhexuany
Copy link
Contributor

zhexuany commented Jun 24, 2018

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    If possible, provide a recipe for reproducing the error.

  2. change your timezone to Thailand

  3. run make dev at root directory of tidb.

  4. What did you expect to see?
    All tests are passed.

  5. What did you see instead?

gc_worker_test.go:88:
    c.Assert(err, IsNil)
... value *errors.Err = &errors.Err{message:"", cause:(*time.ParseError)(0xc429653c20), previous:(*errors.Err)(0xc429653cc0), file:"/Users/zhexuany/repo/go/src/github.com/pingcap/tidb/store/tikv/gcworker/gc_worker.go", line:252} ("parsing time \"20180624-11:39:48 +0700 +07\" as \"20060102-15:04:05 -0700 MST\": cannot parse \"+07\" as \"MST\"")
  1. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?
Release Version: None
Git Commit Hash: None
Git Branch: None
UTC Build Time: None
GoVersion: None
Race Enabled: false
TiKV Min Version: 2.1.0-alpha.1-2f291dc12b0e05d71eb8873881c3ed11d343d6e6

@zhexuany
Copy link
Contributor Author

already created a ticket on go's repo. It seems like its the problem of go's time package.

@zhexuany
Copy link
Contributor Author

golang/go#26029

@zhexuany
Copy link
Contributor Author

Per the discussion with engineer from go team, time.Parse's behavior will be changed after go 1.11. So leave this open and monitor when such version will be released.

@MyonKeminta
Copy link
Contributor

This seems to be fixed by #8745 . How about closing it?

@ghost
Copy link

ghost commented Aug 3, 2020

Sounds good. Thanks!

@ghost ghost closed this as completed Aug 3, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/transaction SIG:Transaction
Projects
None yet
Development

No branches or pull requests

4 participants