Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: refactor CLI backoff retry logic #54643

Closed
Tristan1900 opened this issue Jul 15, 2024 · 0 comments · Fixed by #54644
Closed

br: refactor CLI backoff retry logic #54643

Tristan1900 opened this issue Jul 15, 2024 · 0 comments · Fixed by #54644
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@Tristan1900
Copy link
Contributor

Enhancement

The current BR CLI backoff retry has some redundant logic especially in the NextBackoff. every time creating a new rule needs to impl the NextBackoff. We can probably have one single NextBackoff impl and have errors to retry passed in as set etc. Make it more simplified and easy to extend in the future.
@Tristan1900 Tristan1900 added the type/enhancement The issue or PR belongs to an enhancement. label Jul 15, 2024
@Tristan1900 Tristan1900 mentioned this issue Jul 15, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in 138386c Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br: refactor br cli backoff logic Tristan1900/tidb
1 participant
@Tristan1900