Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: non-prepared plan cache supports queries with more than 200 parameters #44823

Closed
qw4990 opened this issue Jun 20, 2023 · 1 comment · Fixed by #44829
Closed

planner: non-prepared plan cache supports queries with more than 200 parameters #44823

qw4990 opened this issue Jun 20, 2023 · 1 comment · Fixed by #44829
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. epic/plan-cache sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.

Comments

@qw4990
Copy link
Contributor

qw4990 commented Jun 20, 2023

Enhancement

Currently, if the total number of parameters in a query is more than 200 parameters, it cannot hit the non-prepared plan cache (see https://docs.pingcap.com/tidb/stable/sql-non-prepared-plan-cache#usage-restrictions).
Better to make it configurable, some users may need to cache these queries.
@qw4990 qw4990 added type/enhancement The issue or PR belongs to an enhancement. epic/plan-cache labels Jun 20, 2023
@qw4990 qw4990 mentioned this issue Jun 20, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the affects-7.1 This bug affects the 7.1.x(LTS) versions. label Jun 20, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 20, 2023

Use set @@tidb_opt_fix_control = "44823:1000" to set the maximum number to 1000, and 0 means no limitation there.

ti-chi-bot bot pushed a commit that referenced this issue Jun 21, 2023
@qw4990
planner: plan cache supports queries with more than 200 parameters (#…
c16b3f6 
…44829)

close #44823
@ti-chi-bot ti-chi-bot mentioned this issue Jun 21, 2023
Merged
12 tasks
@jebter jebter added the sig/planner SIG: Planner label Jul 3, 2023
ti-chi-bot bot pushed a commit that referenced this issue Jul 11, 2023
@ti-chi-bot
planner: plan cache supports queries with more than 200 parameters (#…
86bd3c0 
…44829) (#44852)

close #44823
@time-and-fate time-and-fate mentioned this issue Jul 17, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. epic/plan-cache sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

planner: plan cache supports queries with more than 200 parameters qw4990/tidb
3 participants
@jebter @qw4990 @ti-chi-bot