Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk spill is better placed in actionMuForSoftLimit than actionMuForHardLimit #38398

Open
yilongrong opened this issue Oct 11, 2022 · 1 comment
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@yilongrong
Copy link

Enhancement

The action (distsplillaction sortspillaction) in {{actionMuForHardLimit}}. I think it would be better to put it in {{actionMuForSoftLimit}}. This way, assuming the statement quota memory limit is 1GB, I can set it to trigger disk spill when 50% of the statement memory limit is reached. And the softlimit ratio (default: 0.8) can be set by the user.

actionMuForHardLimit actionMu

@yilongrong yilongrong added the type/enhancement The issue or PR belongs to an enhancement. label Oct 11, 2022
@XuHuaiyu
Copy link
Contributor

ref: #37098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants