Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression test fails for ppc64le #3376

Closed
YugandhaD opened this issue Jun 2, 2017 · 3 comments
Closed

expression test fails for ppc64le #3376

YugandhaD opened this issue Jun 2, 2017 · 3 comments

Comments

@YugandhaD
Copy link
Contributor

I am trying to build and test tidb master branch on ppc64le.
I found that test “github.com/pingcap/tidb/expression” fails on it.
If we run this “github.com/pingcap/tidb/expression” test individually, using "go test" command inside the expression folder, I get following error.

FAIL: builtin_math_test.go:80: testEvaluatorSuite.TestExp

builtin_math_test.go:104:
    c.Assert(v, testutil.DatumEquals, types.NewDatum(t.ret))
... obtained types.Datum = types.Datum{k:0x4, collation:0x0, decimal:0x0, length:0x0, i:4613303445314885482, b:[]uint8(nil), x:interface {}(nil)}
... expected types.Datum = types.Datum{k:0x4, collation:0x0, decimal:0x0, length:0x0, i:4613303445314885481, b:[]uint8(nil), x:interface {}(nil)}

I could find out the issue and I found that it was minor changes in some values. I could fix the issue, and now the test is passing for ppc64le.
Please let me know if you are willing to have this patch for ppc64le.

@ngaut
Copy link
Member

ngaut commented Jun 2, 2017

Please feel free to send a pull request.

@coocood
Copy link
Member

coocood commented Jun 13, 2017

@YugandhaD
Any update?

@shenli
Copy link
Member

shenli commented Jun 20, 2017

This is fixed. Thanks! @YugandhaD

@shenli shenli closed this as completed Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants