Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate test-infra to testify for ddl/fail_test.go #29102

Closed
Tracked by #27180
tisonkun opened this issue Oct 26, 2021 · 6 comments
Closed
Tracked by #27180

migrate test-infra to testify for ddl/fail_test.go #29102

tisonkun opened this issue Oct 26, 2021 · 6 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@tisonkun
Copy link
Contributor

No description provided.

@tisonkun tisonkun mentioned this issue Oct 26, 2021
Closed
34 tasks
@tisonkun tisonkun added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 26, 2021
@s4kh
Copy link

s4kh commented Oct 26, 2021

if possible can you provide some instructions?

@tisonkun
Copy link
Contributor Author

@s4kh You can just refer to the tracking issue #26022 and follow other tasks already done in ddl package #27180.

There is not a step-by-step instruction, it's better to find your own solution and ask the concrete question.

@s4kh
Copy link

s4kh commented Oct 26, 2021

/assign

@s4kh s4kh mentioned this issue Oct 26, 2021
Closed
@s4kh
Copy link

s4kh commented Oct 26, 2021

@tisonkun in the draft PR fail_test.go is migrated but it uses functions from different tests and all those are required to change in order for this PR to be merged. Maybe grouping related tests into one? or remove those tests from fail_test.go?

@tisonkun
Copy link
Contributor Author

tisonkun commented Oct 26, 2021 •
edited
Loading

@s4kh please take #27747 as an example.

Not only the code, but also the comments. Your draft PR meets several common cases.

@tisonkun tisonkun mentioned this issue Feb 14, 2022
Merged
12 tasks
@tisonkun
Copy link
Contributor Author

Closed by #31313.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: migrate to testify s4kh/tidb
2 participants
@s4kh @tisonkun