Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate test-infra to testify for privilege/privileges pkg #26746

Closed
Tracked by #26022
tisonkun opened this issue Jul 30, 2021 · 2 comments · Fixed by #26991
Closed
Tracked by #26022

migrate test-infra to testify for privilege/privileges pkg #26746

tisonkun opened this issue Jul 30, 2021 · 2 comments · Fixed by #26991
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@tisonkun
Copy link
Contributor

No description provided.

@tisonkun tisonkun added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jul 30, 2021
@Ranxy
Copy link
Contributor

Ranxy commented Aug 2, 2021

/assign

@xhebox
Copy link
Contributor

xhebox commented Aug 9, 2021

I noticed mustExec in #26991, maybe testkit can support ExecuteInternal, then mustExec can be replaced by createMockStore and testkit.MustExecInternal or so. @tisonkun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants