Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PartitionTableReader for query on partition table #18546

Closed
imtbkcat opened this issue Jul 14, 2020 · 2 comments
Closed

Implement PartitionTableReader for query on partition table #18546

imtbkcat opened this issue Jul 14, 2020 · 2 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.
Milestone
v5.0.0 ga

Comments

@imtbkcat
Copy link

Feature Request

Is your feature request related to a problem? Please describe:

Originally, query on partition table would be deal in plan building phase. This bring some performance issues like:

  • Plan of partition table can not be cached in prepare plan cache.
  • Some condition relay on runtime result can not be pruned.

Describe the feature you'd like:

  • Create a PartitionTableReader to replace Union Partition
  • Build range and pruning partition
  • build key range

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

https://docs.google.com/document/d/1pwQ8nzROQcV956jqcmbcikMPveQQWfsUZq2Zd7R8xQM/edit#heading=h.efxhx09hxyyo
@imtbkcat imtbkcat added the type/feature-request Categorizes issue or PR as related to a new feature. label Jul 14, 2020
@imtbkcat imtbkcat added the type/enhancement The issue or PR belongs to an enhancement. label Jul 14, 2020
@scsldb scsldb mentioned this issue Jul 15, 2020
Closed
4 tasks
@scsldb scsldb added the feature/reviewing This feature request is reviewing by product managers label Jul 16, 2020
@zhangjinpeng87 zhangjinpeng87 added feature/accepted This feature request is accepted by product managers and removed feature/reviewing This feature request is reviewing by product managers labels Jul 16, 2020
@zhangjinpeng87 zhangjinpeng87 added this to the v5.0.0-alpha milestone Jul 16, 2020
@jebter jebter modified the milestones: v5.0.0-alpha, v5.0.0-rc Jan 7, 2021
@jebter jebter modified the milestones: v5.0.0-rc, v5.0.0 Jan 18, 2021
@zz-jason zz-jason removed feature/accepted This feature request is accepted by product managers type/feature-request Categorizes issue or PR as related to a new feature. labels Apr 21, 2021
@zz-jason
Copy link
Member

it's more like a performance enhancement than a feature request, moved it out of the kanban.

@qw4990
Copy link
Contributor

qw4990 commented Apr 22, 2021

Close it now since it is duplicated with #24150

@qw4990 qw4990 closed this as completed Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
v5.0.0 ga
Development

No branches or pull requests
7 participants
@tiancaiamao @jebter @zz-jason @scsldb @qw4990 @imtbkcat @zhangjinpeng87