Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin can't load with -trimpath TiDB-server in go1.13 #12927

Closed
lysu opened this issue Oct 25, 2019 · 1 comment · Fixed by #13455
Closed

plugin can't load with -trimpath TiDB-server in go1.13 #12927

lysu opened this issue Oct 25, 2019 · 1 comment · Fixed by #13455
Assignees
Labels
type/bug The issue is confirmed as a bug.

Comments

@lysu
Copy link
Contributor

lysu commented Oct 25, 2019

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    If possible, provide a recipe for reproducing the error.

Thx wph95's report

build load conn_example plugin in TiDB repo using go1.13, will meet

'2019/10/24 21:33:56.735 terror.go:342: [fatal] plugin.Open(~/Work/lab/tidb/plugin/out/conn_ip_example-1"): plugin was built with a different version of package internal/cpu'

this is introduced by #12639 that add -trimpath in make file.

  1. What did you expect to see?

load success

  1. What did you see instead?

load failure

  1. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?

4.0 alpha, master

@lysu lysu added type/bug The issue is confirmed as a bug. status/TODO labels Oct 25, 2019
@lysu
Copy link
Contributor Author

lysu commented Oct 25, 2019

there are a go issue golang/go#31278 (comment) related to this and didn't fix.

so It's better keep 1.12 or remove -trimpath to build TiDB-server that need load plugin

@lysu lysu changed the title plugin can't load with -trimpath in go1.13 plugin can't load with -trimpath TiDB-server in go1.13 Oct 25, 2019
@lysu lysu removed the status/TODO label Nov 14, 2019
@lysu lysu self-assigned this Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant