Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGNORE NULLS in window function not implemented but no error thrown #10556

Closed
winoros opened this issue May 21, 2019 · 4 comments · Fixed by #11554
Closed

IGNORE NULLS in window function not implemented but no error thrown #10556

winoros opened this issue May 21, 2019 · 4 comments · Fixed by #11554
Assignees
@lzmhhh123
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/bug The issue is confirmed as a bug.

Comments

@winoros
Copy link
Member

winoros commented May 21, 2019

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    If possible, provide a recipe for reproducing the error.
SELECT FIRST_VALUE(i) IGNORE NULLS OVER () FROM t1;
  1. What did you expect to see?

Error thrown, This version of TiDB hasn't supported IGNORE NULLS currently.

  1. What did you see instead?

executes successfully.

  1. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?
@winoros winoros added the type/bug The issue is confirmed as a bug. label May 21, 2019
@SunRunAway
Copy link
Contributor

The expected error should be similar with mysql output.

ERROR 1235 (42000): This version of MySQL doesn't yet support 'IGNORE NULLS'

@SunRunAway SunRunAway added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jul 2, 2019
@SunRunAway SunRunAway mentioned this issue Jul 2, 2019
Closed
11 tasks
@wty4427300
Copy link
Contributor

/assign

@SunRunAway
Copy link
Contributor

Ping @wty4427300 , any update?

@lzmhhh123 lzmhhh123 assigned lzmhhh123 and unassigned wty4427300 Jul 29, 2019
@lzmhhh123
Copy link
Contributor

@SunRunAway This version of MySQL or TiDB? May TiDB is better?

@lzmhhh123 lzmhhh123 mentioned this issue Aug 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzmhhh123 lzmhhh123

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

planner: fix bug that window function do not check ignore nulls. lzmhhh123/tidb
4 participants
@SunRunAway @winoros @lzmhhh123 @wty4427300