Skip to content

Commit

Permalink
planner: remove useless pointer receiver implementation. (#55292)
Browse files Browse the repository at this point in the history
ref #51664, ref #52714
  • Loading branch information
AilinKid authored Aug 8, 2024
1 parent 0a2d5be commit d0c1ca1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions pkg/planner/core/indexmerge_path.go
Original file line number Diff line number Diff line change
Expand Up @@ -1003,7 +1003,7 @@ func (ds *DataSource) generateIndexMerge4ComposedIndex(normalPathCnt int, indexM
}
}

mvp := ds.buildPartialPathUp4MVIndex(combinedPartialPaths, true, tableFilters, ds.TableStats.HistColl)
mvp := buildPartialPathUp4MVIndex(combinedPartialPaths, true, tableFilters, ds.TableStats.HistColl)

ds.PossibleAccessPaths = append(ds.PossibleAccessPaths, mvp)
return nil
Expand Down Expand Up @@ -1085,7 +1085,7 @@ func (ds *DataSource) generateIndexMerge4MVIndex(normalPathCnt int, filters []ex
path.IndexFilters = append(path.IndexFilters, clonedIdxFilters...)
}

ds.PossibleAccessPaths = append(ds.PossibleAccessPaths, ds.buildPartialPathUp4MVIndex(
ds.PossibleAccessPaths = append(ds.PossibleAccessPaths, buildPartialPathUp4MVIndex(
partialPaths,
isIntersection,
tableFilters,
Expand All @@ -1097,7 +1097,7 @@ func (ds *DataSource) generateIndexMerge4MVIndex(normalPathCnt int, filters []ex
}

// buildPartialPathUp4MVIndex builds these partial paths up to a complete index merge path.
func (*DataSource) buildPartialPathUp4MVIndex(
func buildPartialPathUp4MVIndex(
partialPaths []*util.AccessPath,
isIntersection bool,
remainingFilters []expression.Expression,
Expand Down
2 changes: 1 addition & 1 deletion pkg/planner/core/indexmerge_unfinished_path.go
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,6 @@ func buildIntoAccessPath(
}

// 3. Build the final access path
ret := ds.buildPartialPathUp4MVIndex(partialPaths, false, tableFilter, ds.TableStats.HistColl)
ret := buildPartialPathUp4MVIndex(partialPaths, false, tableFilter, ds.TableStats.HistColl)
return ret
}

0 comments on commit d0c1ca1

Please sign in to comment.