From 826d92eeaca93fcbc711617904674d704db28c91 Mon Sep 17 00:00:00 2001
From: wshwsh12 <793703860@qq.com>
Date: Thu, 18 May 2023 16:49:19 +0800
Subject: [PATCH] address comments

---
 planner/core/rule_aggregation_push_down.go | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/planner/core/rule_aggregation_push_down.go b/planner/core/rule_aggregation_push_down.go
index c91b0f2280e68..2d3d0a607e9ce 100644
--- a/planner/core/rule_aggregation_push_down.go
+++ b/planner/core/rule_aggregation_push_down.go
@@ -542,8 +542,12 @@ func (a *aggregationPushDownSolver) aggPushDown(p LogicalPlan, opt *logicalOptim
 					for j := range funcsArgs {
 						if oldAggFuncsArgs[i][j].GetType().EvalType() != newAggFuncsArgs[i][j].GetType().EvalType() {
 							noSideEffects = false
+							break
 						}
 					}
+					if !noSideEffects {
+						break
+					}
 				}
 				if noSideEffects {
 					agg.GroupByItems = newGbyItems