Changed FTWRL to produce error (#7712)

pingcap · Oct 12, 2018 · 508a836 · 508a836
1 parent e442d9a
commit 508a836
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/executor/simple.go b/executor/simple.go
@@ -325,7 +325,9 @@ func (e *SimpleExec) executeKillStmt(s *ast.KillStmt) error {
 func (e *SimpleExec) executeFlush(s *ast.FlushStmt) error {
 	switch s.Tp {
 	case ast.FlushTables:
-		// TODO: A dummy implement
+		if s.ReadLock {
+			return errors.New("FLUSH TABLES WITH READ LOCK is not supported.  Please use @@tidb_snapshot")
+		}
 	case ast.FlushPrivileges:
 		dom := domain.GetDomain(e.ctx)
 		sysSessionPool := dom.SysSessionPool()

diff --git a/executor/simple_test.go b/executor/simple_test.go
@@ -296,3 +296,14 @@ func (s *testSuite) TestDropStats(c *C) {
 	c.Assert(statsTbl.Pseudo, IsTrue)
 	h.Lease = 0
 }
+
+func (s *testSuite) TestFlushTables(c *C) {
+	tk := testkit.NewTestKit(c, s.store)
+
+	_, err := tk.Exec("FLUSH TABLES")
+	c.Check(err, IsNil)
+
+	_, err = tk.Exec("FLUSH TABLES WITH READ LOCK")
+	c.Check(err, NotNil)
+
+}