Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recommendations options to mydumper (#828) #844

Merged
merged 2 commits into from
Aug 29, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Aug 29, 2019

cherry-pick #828 to release-1.0


What problem does this PR solve?

add recommendations options to mydumper:

https://pingcap.com/docs/v3.0/how-to/maintain/backup-and-restore/#best-practices-of-full-backup-and-restoration-using-mydumper-loader

  • -t 16: means 16 threads are used to export the data.
  • -F 64: means a table is partitioned into chunks and one chunk is 64MB.
  • --skip-tz-utc: the purpose of adding this parameter is to ignore the inconsistency of time zone setting between MySQL and the data exporting machine and to disable automatic conversion.

What is changed and how does it work?

Check List

Tests

Code changes

  • Has Helm charts change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

add recommendations options to mydumper: `-t 16 -F 64 --skip-tz-utc`

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor

/run-e2e-in-kind

@weekface weekface merged commit 47d8735 into pingcap:release-1.0 Aug 29, 2019
@dragonly dragonly mentioned this pull request Nov 12, 2020
7 tasks
yahonda pushed a commit that referenced this pull request Dec 27, 2021
* en, zh: bump tidb version to 4.0.8

* fix versions accidentally upgraded

Co-authored-by: Ran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants