Enable configmap rollout by default and quote configmap digest suffix #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
|
/run-e2e-tests |
weekface
approved these changes
Jul 22, 2019
weekface
pushed a commit
that referenced
this pull request
Jul 29, 2019
…#678) * Fix helm rendering error when configmap SHA only consists of digits Signed-off-by: Aylei <[email protected]> * Enable configmap rollout by default Signed-off-by: Aylei <[email protected]> (cherry picked from commit 20e8cf2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Enable configmap rollout by default and quote configmap digest suffix
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: