Alibaba Cloud multiple tidb clusters management support #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aylei <[email protected]>
- fix hardcode chart version - fix unreachable bastion - adjust tidb-cluster no-wait to avoid scheduled backup pvc blocking - add version check - disable pd node public_ip Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
5 tasks
aylei
requested review from
AstroProfundis,
tennix and
onlymellb
and removed request for
AstroProfundis
3 tasks
Signed-off-by: Aylei <[email protected]>
|
Please resolve the conflict. |
Signed-off-by: Aylei <[email protected]>
|
@tennix done |
|
/run-e2e-tests |
Signed-off-by: Aylei <[email protected]>
… into aliyun-multi-cluster
|
@tennix @onlymellb I've addressed some merge conflicts, could you please take a look again? |
|
/run-e2e-tests |
weekface
approved these changes
Jul 23, 2019
|
|
||
| variable "tidb_cluster_chart_version" { | ||
| description = "tidb-cluster chart version" | ||
| default = "v1.0.0-beta.3" |
tennix
approved these changes
Jul 23, 2019
weekface
pushed a commit
that referenced
this pull request
Jul 29, 2019
* Refactor aliyun tf to multiple cloud Signed-off-by: Aylei <[email protected]> * Small fixes for terraform aws - fix hardcode chart version - fix unreachable bastion - adjust tidb-cluster no-wait to avoid scheduled backup pvc blocking - add version check - disable pd node public_ip Signed-off-by: Aylei <[email protected]> * aliyun multiple cluster Signed-off-by: Aylei <[email protected]> * Modularization for AWS terraform scripts Signed-off-by: Aylei <[email protected]> * Refine README of AWS terraform Signed-off-by: Aylei <[email protected]> * Fix bastion ssh Signed-off-by: Aylei <[email protected]> * Alibaba cloud multiple clusters support Signed-off-by: Aylei <[email protected]> * Fix endpoints output Signed-off-by: Aylei <[email protected]> (cherry picked from commit 042b1a9)
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* en: update tls doc for tiflash Signed-off-by: Ran <[email protected]> * Apply suggestions from code review Co-authored-by: TomShawn <[email protected]> Co-authored-by: TomShawn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add multiple tidb clusters management support in Alibaba Cloud
What is changed and how does it work?
Some reusable sub modules are created just like aws #650 , the scripts in
deploy/aliyunare changed accordingly to compose one kubernetes cluster with one or more tidb clusters.Also, the
READMEandREADME-CNand removed and the users are redirected todocs-cnanddocsin favor of consistency.This PR is based on an un-merged PR #650 , so there will be some commits that are no belong to this PR, please follow this link to see the actual patch: https://github.com/pingcap/tidb-operator/pull/658/files/f07c30c58aa83b85d3aee167f84884d704085755
Check List
Tests
Related changes
Does this PR introduce a user-facing change?: