Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo #483

Merged
merged 1 commit into from
May 14, 2019
Merged

Fixed typo #483

merged 1 commit into from
May 14, 2019

Conversation

ceohockey60
Copy link
Contributor

@ceohockey60 ceohockey60 commented May 10, 2019 •
edited by weekface
Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Helm charts change
  • Has Go code change
  • Has CI related scripts change
  • Has documents change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

tennix
tennix approved these changes May 11, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LinuxGit
LinuxGit approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@LinuxGit LinuxGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix tennix merged commit eafedeb into pingcap:master May 14, 2019
yahonda pushed a commit that referenced this pull request Dec 27, 2021
@PengJi @ti-srebot
en, zh: add scheduler scheduling based on customer topology (#483)
3a327d7 
Co-authored-by: ti-srebot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tennix tennix tennix approved these changes

@LinuxGit LinuxGit LinuxGit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ceohockey60 @LinuxGit @tennix