stability test: async emit annotations #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* operator image pull policy to always * increase tidbcluster memory and cpu * update to v2.1.7 * fix truncate sst case * default concurrency to 12 * run stability test forever
Co-Authored-By: weekface <[email protected]>
xiaojingchen
previously approved these changes
Apr 30, 2019
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
aylei
reviewed
May 6, 2019
| if b, err := oa.metaSyncFn(tc); !b && err == nil { | ||
| return false, nil | ||
| } else if err != nil { | ||
| glog.Error(err) |
There was a problem hiding this comment.
could you document why this error can be omitted?
There was a problem hiding this comment.
other sync functions log the error immediately. metaSyncFn return these errors and log them outside of the method.
these may be different coding styles.
xiaojingchen
approved these changes
May 7, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* fix monitor * address comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This pr fixes stability tests:
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes