no need to set ClusterIP when syncing headless service #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weekface
previously approved these changes
Apr 28, 2019
LinuxGit
changed the title
|
I added a commit to remove op in tidb_member_manager.go and dismissed your review. |
| @@ -152,8 +152,6 @@ func (pmm *pdMemberManager) syncPDHeadlessServiceForTidbCluster(tc *v1alpha1.Tid | |||
| if !equal { | |||
| svc := *oldSvc | |||
| svc.Spec = newSvc.Spec | |||
| // TODO add unit test | |||
| svc.Spec.ClusterIP = oldSvc.Spec.ClusterIP | |||
There was a problem hiding this comment.
this line is to ensure that the ClusterIP remains unchanged when svc updated.
There was a problem hiding this comment.
Yes. syncPDServiceForTidbCluster should keep ClusterIP unchanged. But when syncPDHeadlessServiceForTidbCluster, there's no need to set it, it should be default value of 'None' from newSvc.Spec.
| @@ -115,8 +115,6 @@ func (tmm *tidbMemberManager) syncTiDBHeadlessServiceForTidbCluster(tc *v1alpha1 | |||
| if !equal { | |||
| svc := *oldSvc | |||
| svc.Spec = newSvc.Spec | |||
| // TODO add unit test | |||
| svc.Spec.ClusterIP = oldSvc.Spec.ClusterIP | |||
xiaojingchen
approved these changes
Apr 29, 2019
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
weekface
approved these changes
May 5, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* Update access-dashboard.md * fix md lint Co-authored-by: DanielZhangQD <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
remove set ClusterIP operation when syncing headless service
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes