Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump operator to v1.2.0 #4105

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Bump operator to v1.2.0 #4105

merged 1 commit into from
Jul 29, 2021

Conversation

KanShiori
Copy link
Collaborator

What problem does this PR solve?

ref #4057.

run script hack/bump-version.sh, and correct some comments by hand.

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 29, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • DanielZhangQD
  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

DanielZhangQD
DanielZhangQD approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 595cd7e

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2021 •
edited
Loading

Codecov Report

Merging #4105 (595cd7e) into master (06bebe6) will increase coverage by 9.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4105      +/-   ##
==========================================
+ Coverage   61.16%   70.37%   +9.20%     
==========================================
  Files         178      182       +4     
  Lines       18883    21172    +2289     
==========================================
+ Hits        11550    14899    +3349     
+ Misses       6193     5110    -1083     
- Partials     1140     1163      +23
Flag Coverage Δ
e2e 57.73% <ø> (?)
unittest 61.16% <ø> (-0.01%) ⬇️

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind

@KanShiori KanShiori mentioned this pull request Jul 29, 2021
Closed
9 tasks
@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind

@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind-serial

@ti-chi-bot ti-chi-bot merged commit 33bf21c into pingcap:master Jul 29, 2021
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Jul 29, 2021
@KanShiori @ti-srebot
cherry pick pingcap#4105 to release-1.2
d2ee8dc 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jul 29, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-1.2 in PR #4106

@KanShiori KanShiori deleted the bump-version-1.2.0 branch July 29, 2021 05:22
DanielZhangQD pushed a commit that referenced this pull request Jul 29, 2021
@ti-srebot @KanShiori
cherry pick #4105 to release-1.2 (#4106)
824d648 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Shiori <[email protected]>
@KanShiori KanShiori mentioned this pull request Aug 17, 2021
Merged
10 tasks
@ti-srebot ti-srebot mentioned this pull request Aug 17, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-1.2 status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KanShiori @ti-chi-bot @csuzhangxc @codecov-commenter @DanielZhangQD @ti-srebot