Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump helm to v2.17.0 (#3611) #3650

Merged
merged 8 commits into from
Dec 28, 2020
Merged

Bump helm to v2.17.0 (#3611) #3650

merged 8 commits into from
Dec 28, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #3611 to release-1.1

What problem does this PR solve?

bump helm to v2.17.0
Fix #3610

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

NONE

@ti-srebot ti-srebot mentioned this pull request Dec 25, 2020
Merged
10 tasks
@ti-srebot ti-srebot added this to the v1.1.9 milestone Dec 25, 2020
@ti-chi-bot ti-chi-bot requested a review from lonng December 25, 2020 03:33
@ti-srebot
Copy link
Contributor Author

@dragonly you're already a collaborator in bot's repo.

@DanielZhangQD
Copy link
Contributor

DanielZhangQD commented Dec 25, 2020 •
edited
Loading

@shonge Please help fix the conflict.

@codecov-io
Copy link

codecov-io commented Dec 25, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-1.1@e3b8b25). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-1.1    #3650   +/-   ##
==============================================
  Coverage               ?   52.04%           
==============================================
  Files                  ?      153           
  Lines                  ?    14893           
  Branches               ?        0           
==============================================
  Hits                   ?     7751           
  Misses                 ?     6406           
  Partials               ?      736
Flag Coverage Δ
unittest 52.04% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@shonge
Copy link
Member

shonge commented Dec 25, 2020

@shonge Please help fix the conflict.

Done ti-srebot#2

@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind-serial

@DanielZhangQD
Copy link
Contributor

/run-all-tests

1 similar comment
@DanielZhangQD
Copy link
Contributor

/run-all-tests

@DanielZhangQD DanielZhangQD modified the milestones: v1.1.9, v1.1.10 Dec 28, 2020
DanielZhangQD
DanielZhangQD approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD DanielZhangQD merged commit fadc084 into pingcap:release-1.1 Dec 28, 2020
@shonge shonge deleted the release-1.1-997286b692bd branch December 29, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@csuzhangxc csuzhangxc Awaiting requested review from csuzhangxc

@dragonly dragonly Awaiting requested review from dragonly

@handlerww handlerww Awaiting requested review from handlerww

@sdojjy sdojjy Awaiting requested review from sdojjy

@lonng lonng Awaiting requested review from lonng

Assignees

@dragonly dragonly

Labels
status/LGT1
Projects
None yet
Milestone
v1.1.10
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @DanielZhangQD @codecov-io @shonge @dragonly @ti-chi-bot