Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump helm to v2.17.0 #3611

Merged
merged 9 commits into from
Dec 25, 2020
Merged

Bump helm to v2.17.0 #3611

merged 9 commits into from
Dec 25, 2020

Conversation

shonge
Copy link
Member

@shonge shonge commented Dec 16, 2020

What problem does this PR solve?

bump helm to v2.17.0
Fix #3610

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

NONE

@ti-chi-bot ti-chi-bot requested a review from sdojjy December 16, 2020 09:23
@CLAassistant
Copy link

CLAassistant commented Dec 16, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dragonly
Copy link
Contributor

Since this only affects CI tests, IMO it's better to leave the release notes as NONE.

@codecov-io
Copy link

codecov-io commented Dec 16, 2020

Codecov Report

Merging #3611 (abfb0b3) into master (a887046) will decrease coverage by 0.18%.
The diff coverage is 6.89%.

@@            Coverage Diff             @@
##           master    #3611      +/-   ##
==========================================
- Coverage   62.62%   62.43%   -0.19%     
==========================================
  Files         164      164              
  Lines       17300    17354      +54     
==========================================
+ Hits        10834    10835       +1     
- Misses       5427     5477      +50     
- Partials     1039     1042       +3     
Flag Coverage Δ
unittest 62.43% <6.89%> (?)

@DanielZhangQD
Copy link
Contributor

/run-all-tests

@shonge shonge changed the title Bump helm to v2.17.0 [WIP]Bump helm to v2.17.0 Dec 17, 2020
@shonge shonge changed the title [WIP]Bump helm to v2.17.0 Bump helm to v2.17.0 Dec 24, 2020
@dragonly
Copy link
Contributor

LGTM, nice work 👍

@DanielZhangQD
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: abfb0b3

@ti-chi-bot ti-chi-bot merged commit 997286b into pingcap:master Dec 25, 2020
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Dec 25, 2020
@ti-srebot ti-srebot mentioned this pull request Dec 25, 2020
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #3650

DanielZhangQD added a commit that referenced this pull request Dec 28, 2020
* cherry pick #3611 to release-1.1
* update e2e Verify Upgrading Operator from v1.1.7

Co-authored-by: Ge Song <[email protected]>
Co-authored-by: Yilong Li <[email protected]>
Co-authored-by: DanielZhangQD <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"helm delete tidb-operator --purge" doesn't delete tidb-controller-manager Deployment
7 participants