add scheduled-backup test case #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weekface
reviewed
Mar 18, 2019
tests/actions.go
Outdated
| @@ -252,6 +260,11 @@ func (oa *operatorActions) CleanTidbCluster(info *TidbClusterInfo) error { | |||
| } | |||
| } | |||
|
|
|||
| _, err := oa.kubeCli.CoreV1().Pods(info.Namespace).Get(getBackupDirPodName, metav1.GetOptions{}) | |||
There was a problem hiding this comment.
helm del won't delete these pods?
There was a problem hiding this comment.
this pod is create for get dirs, not manager by helm
tests/actions.go
Outdated
| return fmt.Errorf("failed to launch scheduler backup job: %v", err) | ||
| } | ||
|
|
||
| backupDir, err = oa.getBackupDir(info) |
There was a problem hiding this comment.
Don't use global var backupDir.
tests/actions.go
Outdated
|
|
||
| dirs := strings.Split(string(res), "\n") | ||
| glog.Infof("dirs in pod info name [%s] dir name [%s]", info.Name, strings.Join(dirs, ",")) | ||
| return strings.TrimSpace(dirs[0]), nil |
There was a problem hiding this comment.
should assert the count of dirs
tests/backup/backupcase.go
Outdated
| @@ -70,5 +70,20 @@ func (bc *BackupCase) Run() error { | |||
| return err | |||
| } | |||
|
|
|||
| bc.srcCluster.Name = "demo-scheduled-backup" | |||
| bc.desCluster.Name = "demo-scheduled-backup" | |||
tests/cmd/e2e/main.go
Outdated
| @@ -88,6 +93,7 @@ func main() { | |||
| } | |||
|
|
|||
| restoreClusterInfo := &tests.TidbClusterInfo{ | |||
| Name: "test-backup", | |||
There was a problem hiding this comment.
why the name as same as clusterInfo name?
There was a problem hiding this comment.
the name is pvc name, clusterinfo name is clustername in the test case
weekface
reviewed
Mar 19, 2019
| @@ -49,14 +49,10 @@ func NewOperatorActions(cli versioned.Interface, kubeCli kubernetes.Interface) O | |||
|
|
|||
| const ( | |||
| DefaultPollTimeout time.Duration = 10 * time.Minute | |||
| DefaultPollInterval time.Duration = 1 * time.Minute | |||
| DefaultPollInterval time.Duration = 10 * time.Second | |||
There was a problem hiding this comment.
Why change this to 10 seconds, it will be very noisy
There was a problem hiding this comment.
xiaojing and I need to check the log and scheduledbackup-cronjob is called job every minute
tests/actions.go
Outdated
| @@ -918,11 +913,6 @@ func (oa *operatorActions) CheckAdHocBackup(info *TidbClusterInfo) error { | |||
| return fmt.Errorf("failed to launch scheduler backup job: %v", err) | |||
| } | |||
|
|
|||
| backupDir, err = oa.getBackupDir(info) | |||
There was a problem hiding this comment.
you must ensure the returned backupDir is not empty.
tests/actions.go
Outdated
| @@ -1193,7 +1190,7 @@ func getParentUIDFromJob(j batchv1.Job) (types.UID, bool) { | |||
| return controllerRef.UID, true | |||
| } | |||
|
|
|||
| func (oa *operatorActions) getBackupDir(info *TidbClusterInfo) (string, error) { | |||
| func (oa *operatorActions) getBackupDir(info *TidbClusterInfo) (int, error) { | |||
weekface
pushed a commit
to weekface/tidb-operator
that referenced
this pull request
Mar 21, 2019
* add scheduled-backup test case
tennix
pushed a commit
that referenced
this pull request
Mar 21, 2019
* add scheduled-backup test case
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* en: separate client certificates for each component * Update enable-tls-for-mysql-client.md * Apply suggestions from code review Co-authored-by: TomShawn <[email protected]> * Apply suggestions from code review Co-authored-by: TomShawn <[email protected]> Co-authored-by: TomShawn <[email protected]> Co-authored-by: pingcap-github-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add scheduler test case
2.add a function to get backup dir
@weekface @zyguan @xiaojingchen @tennix @cwen0 PTAL