Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create tidb cluster on ack with cr (#2012) #2020

Merged
merged 4 commits into from
Mar 24, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 24, 2020

cherry-pick #2012 to release-1.1


What problem does this PR solve?

Fix #1914

What is changed and how does it work?

  • Add a variable to the terraform module to not install tidb cluster.
  • Add CR example.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

    • Deploy ack with terraform and then install tidb cluster and tidb monitor with the CRs.
    • Upgrade tidb cluster.
    • Update tidb cluster configuration.
    • Scale out the tidb cluster.
    • Deploy multiple tidb clusters.

Code changes

  • Has Terraform scripts change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Support deploying TiDB Cluster with TidbCluster and TidbMonitor CRs via Terraform on ACK.

@DanielZhangQD
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 24, 2020

/run-all-tests

@sre-bot sre-bot merged commit 23a1bba into pingcap:release-1.1 Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants