lightning: support lightning use IAM (#1975) #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1975 to release-1.1
What problem does this PR solve?
add serviceAccount for config
What is changed and how does it work?
add service Account config to pod template
Check List
Tests
install an importer in tidb cluster
add annotation in annotation field
and set a seviceAccount in values.yaml
follow doc to deploy lightning in tidb cluster and use remote S3 backups to restore , ignore accesskey and
secret key in field
dataSource.remote.secretNamecheck wether initContainer can download file from S3 and the serviceAccount is attach to the tidb-lightning pod
Code changes