Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support starting tidb-server with -advertise-address parameter (#1859) #1868

Merged
merged 4 commits into from
Mar 5, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 5, 2020

cherry-pick #1859 to release-1.1


What problem does this PR solve?

Closes #1439

v2.1.0 and later versions have this argument:
https://github.com/pingcap/tidb/blob/v2.1.0/config/config.go#L48

What is changed and how does it work?

start tidb-server with -advertise-address parameter, refer to pingcap/tidb#7078.

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)

When EnableAdvertiseAddress is set to false:

/ # ps
PID   USER     TIME  COMMAND
    1 root      0:00 /tidb-server --store=tikv --host=0.0.0.0 --path=db-pd:2379 --config=/etc/tidb/tidb.toml --log-slow-query=/var/log/tidb/slowlog

When EnableAdvertiseAddress is set to true:

# kubectl exec -it db-tidb-0 sh -n tidb10 -c tidb
/ # ps
PID   USER     TIME  COMMAND
    1 root      0:01 /tidb-server --store=tikv --advertise-address=db-tidb-0.db-tidb-peer.tidb10.svc --host=0.0.0.0 --path=db-pd:2379 --config=/etc/tidb/tidb
  • No code

Code changes

  • Has Go code change

Related changes

  • Need to cherry-pick to the release branch
    1.1
  • Need to update the documentation

Does this PR introduce a user-facing change?:

support starting tidb-server with `-advertise-address` parameter

@cofyc cofyc merged commit be5c05b into pingcap:release-1.1 Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants