You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What did you expect to see?
We expect to see the update strategy being updated from InPlace to RollingUpdate, as the doc says the update strategy of the component will "Override the cluster-level updateStrategy if present" .
What did you see instead?
We did not see any changes of the update strategy in the discovery deployment.
Additional comment
We inspected the types.go to try to find the root cause. The possible root cause is that the DiscoverySpec struct type inherits the ComponentSpec struct type, and the ComponentSpec type has the configUpdateStrategy field. We guess this ConfigUpdateStrategy is only meant for components that use StatefulSet to deploy. Since the discovery component uses Deployment to deploy, this configUpdateStrategy is never used.
The text was updated successfully, but these errors were encountered:
Bug Report
What version of Kubernetes are you using?
What version of TiDB Operator are you using?
What storage classes exist in the Kubernetes cluster and what are used for PD/TiKV pods?
$ kubectl get sc NAME PROVISIONER RECLAIMPOLICY VOLUMEBINDINGMODE ALLOWVOLUMEEXPANSION AGE standard (default) rancher.io/local-path Delete WaitForFirstConsumer false 9m4s $ kubectl get pvc -n {tidb-cluster-namespace} NAME STATUS VOLUME CAPACITY ACCESS MODES STORAGECLASS AGE pd-advanced-tidb-pd-0 Bound pvc-5d85aab1-3a5b-4bd2-a096-83be8a6e4c63 10Gi RWO standard 8m37s pd-advanced-tidb-pd-1 Bound pvc-22015e6c-601d-409e-b480-07458ce53711 10Gi RWO standard 8m37s pd-advanced-tidb-pd-2 Bound pvc-aa1bfdda-b2be-44ed-a721-a17ef5d6140c 10Gi RWO standard 8m37s tikv-advanced-tidb-tikv-0 Bound pvc-a702225b-1b7f-4363-8975-04f9170f5853 100Gi RWO standard 7m11s tikv-advanced-tidb-tikv-1 Bound pvc-fc633404-97d4-4359-9921-61faaf26b4c8 100Gi RWO standard 7m11s tikv-advanced-tidb-tikv-2 Bound pvc-69b6c9eb-6dcf-4ae6-91b8-912551c3c1d4 100Gi RWO standard 7m11s
What's the status of the TiDB cluster pods?
What did you do?
We modified the field
configUpdateStrategy
underdiscovery
toRollingUpdate
. The CR file we used is shown below:CR file
What did you expect to see?
We expect to see the update strategy being updated from
InPlace
toRollingUpdate
, as the doc says the update strategy of the component will "Override the cluster-level updateStrategy if present" .What did you see instead?
We did not see any changes of the update strategy in the
discovery
deployment.Additional comment
We inspected the types.go to try to find the root cause. The possible root cause is that the
DiscoverySpec
struct type inherits theComponentSpec
struct type, and theComponentSpec
type has theconfigUpdateStrategy
field. We guess thisConfigUpdateStrategy
is only meant for components that useStatefulSet
to deploy. Since thediscovery
component usesDeployment
to deploy, thisconfigUpdateStrategy
is never used.The text was updated successfully, but these errors were encountered: