Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a random password after TiDB installation #4326

Closed
DanielZhangQD opened this issue Dec 24, 2021 · 3 comments · Fixed by #4389
Closed

Create a random password after TiDB installation #4326

DanielZhangQD opened this issue Dec 24, 2021 · 3 comments · Fixed by #4389
Assignees
Milestone

Comments

@DanielZhangQD
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe:

Currently, TiDB will create a root user with no password by default. This is a potential security issue.
So we have to create a random password after TiDB is installed.
We can add a field in the spec to control whether to create a random password after installation, if yes, we can save the password in a secret and request the user to access the TiDB with that password and then change the password.
TiDB will force the user to change the password after the first login in future releases.
Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@yiduoyunQ
Copy link
Contributor

yiduoyunQ commented Jan 13, 2022

why we need implement save the password in a secret logic in operator side, not tidb side itself (by default)?

@DanielZhangQD
Copy link
Contributor Author

why we need implement save the password in a secret logic in operator side, not tidb side itself (by default)?

@yiduoyunQ The password is created by TiDB Operator, it's reasonable to be saved by TiDB Operator too, where do you suggest saving the password?

@yiduoyunQ
Copy link
Contributor

@DanielZhangQD seems TiUP is also responsible for creating random password after TiDB installation with --init argument #1700 , then it is meaningful to implement the same logic in TiDB Operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants