Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify ServiceAccount for tidb-lightning #1781

Closed
tirsen opened this issue Feb 26, 2020 · 2 comments
Closed

Specify ServiceAccount for tidb-lightning #1781

tirsen opened this issue Feb 26, 2020 · 2 comments
Assignees
@shuijing198799
Labels
enhancement New feature or request priority:P1
Milestone
v1.1.0

Comments

@tirsen
Copy link
Contributor

tirsen commented Feb 26, 2020

Feature Request

Is your feature request related to a problem? Please describe:
Right now tidb-lightning can only run as the default service account

Describe the feature you'd like:
We would like to be able to run tidb-lightning as a different service account so that it can access S3 through an IAM role. Just like tidb-backup currently can:

# Kubernetes service account to use
serviceAccount: s3-reader
@cofyc cofyc added the enhancement New feature or request label Feb 27, 2020
@DanielZhangQD DanielZhangQD added this to the v1.1.0 milestone Mar 9, 2020
@DanielZhangQD
Copy link
Contributor

@shuijing198799 Please make sure that both IAM role with annotations and serviceAccount work as expected.

@shuijing198799
Copy link
Contributor

It wiil support specify a serviceaccount to lightning after this PR is merge #1975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shuijing198799 shuijing198799

Labels
enhancement New feature or request priority:P1
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
4 participants
@tirsen @cofyc @shuijing198799 @DanielZhangQD