Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UCP: Add toleration support for discovery deployment in tidb-cluster chart #1701

Closed
DanielZhangQD opened this issue Feb 14, 2020 · 2 comments
Closed

UCP: Add toleration support for discovery deployment in tidb-cluster chart #1701

DanielZhangQD opened this issue Feb 14, 2020 · 2 comments
Labels
challenge-program-2 difficulty/easy good first issue Good for newcomers status/help-wanted Extra attention is needed

Comments

@DanielZhangQD
Copy link
Contributor

DanielZhangQD commented Feb 14, 2020 •
edited by cofyc
Loading

Description

Currently, when we deploy tidb cluster with helm chart, it's unable to configure toleration for discovery deployment. We should support it in helm chart.

Score

  • 50

Mentor(s)

Contact the mentors: #tidb-challenge-program channel in TiDB-Operator Community Slack Workspace

Recommended Skills

  • Kubernetes
  • Helm

Learning Materials
@cofyc cofyc added enhancement New feature or request good first issue Good for newcomers labels Feb 20, 2020
@cofyc cofyc added challenge-program-2 good first issue Good for newcomers difficulty/easy status/help-wanted Extra attention is needed and removed enhancement New feature or request good first issue Good for newcomers labels Mar 11, 2020
@cofyc cofyc changed the title cannot set toleration for discovery deployment UCP: Add toleration support for discovery deployment in tidb-cluster chart Mar 11, 2020
@shonge shonge mentioned this issue Mar 16, 2020
Closed
@shonge
Copy link
Member

shonge commented Mar 16, 2020

/pick-up-challenge

@Smana Smana mentioned this issue Mar 17, 2020
Merged
@sre-bot sre-bot mentioned this issue Mar 17, 2020
Merged
@cofyc
Copy link
Contributor

cofyc commented Mar 26, 2020

closed via #1959.

@cofyc cofyc closed this as completed Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
challenge-program-2 difficulty/easy good first issue Good for newcomers status/help-wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cofyc @shonge @DanielZhangQD