Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Service port name configurable for tidb and pd service #1538

Closed
Yisaer opened this issue Jan 10, 2020 · 9 comments
Closed

Make Service port name configurable for tidb and pd service #1538

Yisaer opened this issue Jan 10, 2020 · 9 comments
Assignees
@mikechengwei
Labels
good first issue Good for newcomers

Comments

@Yisaer
Copy link
Contributor

Yisaer commented Jan 10, 2020

Feature Request

Is your feature request related to a problem? Please describe:

We need to make service port name configurable for tidb and pd service. Currently, #1521 would make monitor service port name configurable.

Describe the feature you'd like:

The default service port name for tidb is mysql-tidb. For the default pd service port name, when enableTLS is not enabled, it is http-pd. If enabled, the default service port name is https-pd.
@Yisaer Yisaer added the good first issue Good for newcomers label Jan 10, 2020
@Yisaer Yisaer mentioned this issue Jan 10, 2020
Merged
@mikechengwei
Copy link
Contributor

I have optimize pd service config before, so this issue can be assigned to me. @Yisaer

@Yisaer
Copy link
Contributor Author

Yisaer commented Feb 3, 2020

@mikechengwei Sure, feel free to go ahead.

@Yisaer
Copy link
Contributor Author

Yisaer commented Feb 24, 2020

@mikechengwei Hi, is this issue still WIP? Do I need reassign this issue?

@mikechengwei
Copy link
Contributor

Sorry.I will finish it this week.ok?

@Yisaer
Copy link
Contributor Author

Yisaer commented Feb 24, 2020

@mikechengwei Thanks, take your time.

This was referenced Feb 28, 2020
Closed
Merged
@sre-bot sre-bot mentioned this issue Mar 10, 2020
Merged
@cofyc
Copy link
Contributor

cofyc commented Mar 10, 2020

has it been resolved now?

@mikechengwei
Copy link
Contributor

I think it have been finished.

@cofyc
Copy link
Contributor

cofyc commented Mar 10, 2020

Thanks.
Closed via #1823.

@cofyc cofyc closed this as completed Mar 10, 2020
@cofyc
Copy link
Contributor

cofyc commented Mar 10, 2020 •
edited
Loading

@mikechengwei next time, you can use these keywords in your PR to close issue automatically ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikechengwei mikechengwei

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cofyc @mikechengwei @Yisaer