Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Advanced StatefulSet] e2e case: delete the failed pod after a failover #1464

Closed
cofyc opened this issue Jan 2, 2020 · 2 comments · Fixed by #2560
Closed

[Advanced StatefulSet] e2e case: delete the failed pod after a failover #1464

cofyc opened this issue Jan 2, 2020 · 2 comments · Fixed by #2560
Assignees

Comments

@cofyc
Copy link
Contributor

cofyc commented Jan 2, 2020

Feature Request

Describe the feature you'd like:

an example:

  • (normal) tc.spec.tikv.replicas = 3, sts.spec.replicas = 3
  • (failover) tc.spec.tikv.replicas = 3, sts.spec.replicas = 4 ( tc.spec.tikv.replicas + len(tc.status.tikv.failureStores))
  • delete the failed pod
    • if the failed pod is not expected to exist, we should delete it from the cc.status.tikv.failureMembers
  • (after the deletion) tc.spec.tikv.replicas = 3, sts.spec.replicas = 3 ( tc.spec.tikv.replicas + len(tc.status.tikv.failureMembers))
@cofyc cofyc added the test/e2e e2e test label Jan 2, 2020
@cofyc cofyc changed the title e2e test case: delete the failed pod after a failover [Advanced StatefulSet] e2e case: delete the failed pod after a failover Feb 4, 2020
@cofyc cofyc added this to the v1.1.0 milestone Feb 4, 2020
@cofyc cofyc self-assigned this Mar 10, 2020
@cofyc
Copy link
Contributor Author

cofyc commented Apr 1, 2020

I thought about it some more and think this case is meaningless. It's not the right to delete failover replicas. The auto-failover controller adds new replicas by increasing the replicas of the statefulset. According to our best practice, users should delete the entries in tikv.failureStores to decrease desired replicas of tikv statefulset.

@cofyc cofyc closed this as completed Apr 1, 2020
@cofyc
Copy link
Contributor Author

cofyc commented Apr 3, 2020

ah, one meaningful use case is to blacklist the failed pod to prevent it from being recreated again when deleting it from tikv.failureStores.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants