Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start tidb-server with -advertise-address #1439

Closed
nolouch opened this issue Dec 30, 2019 · 4 comments · Fixed by #1859
Closed

start tidb-server with -advertise-address #1439

nolouch opened this issue Dec 30, 2019 · 4 comments · Fixed by #1859
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@nolouch
Copy link
Member

nolouch commented Dec 30, 2019

Feature Request

Is your feature request related to a problem? Please describe:

For let PD to know the tidb address.
Describe the feature you'd like:

That need tidb-server startup with --advertise-address, like TiKV:

❯ kubectl exec -it hot-new-tikv-1 -n xxx sh
/ # ps
PID   USER     TIME  COMMAND
    1 root     23d18 /tikv-server --pd=hot-new-pd:2379 --advertise-addr=hot-new-tikv-1.hot-new-tikv-peer.csn.svc:20160 --addr=0.0.0.0:20160 --status-addr=0.0
93992 root      0:00 sh
@tennix tennix added the good first issue Good for newcomers label Dec 30, 2019
@tennix
Copy link
Member

tennix commented Dec 30, 2019

This argument should be added to the startup script of the configmap.

@aylei
Copy link
Contributor

aylei commented Dec 30, 2019

This change will trigger rolling-update of the tidb-servers if the configmap rollout strategy is RollingUpdate. So this deserves a feature name and should be enabled manually on existing clusters.

What's the feature related to this change? @nolouch

@nolouch
Copy link
Member Author

nolouch commented Dec 31, 2019

@aylei PD wants to know all TiDB addresses, and do some proxy worker in TiDB, for example, which table the key belongs to? and also, PD show all competent address as a cluster manager is a reasonable operation.

@tennix
Copy link
Member

tennix commented Jan 7, 2020

Yes, this makes PD knows all the cluster component info. So we can retrieve the single source of true from PD for cluster status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants