Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pump/storge: Measure time taken to write to disk, to rotate and fsync #830

Merged
merged 1 commit into from
Nov 25, 2019
Merged

pump/storge: Measure time taken to write to disk, to rotate and fsync #830

merged 1 commit into from
Nov 25, 2019

Conversation

suzaku
Copy link
Contributor

@suzaku suzaku commented Nov 25, 2019

What problem does this PR solve?

Cherry-pick #773

@suzaku
Copy link
Contributor Author

suzaku commented Nov 25, 2019

/run-all-tests

@suzaku suzaku requested a review from july2993 November 25, 2019 08:15
@IANTHEREAL
Copy link
Collaborator

LGTM

july2993
july2993 reviewed Nov 25, 2019
View reviewed changes
Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993 july2993 merged commit f0dd221 into pingcap:release-2.1 Nov 25, 2019
@suzaku suzaku deleted the pick-measure-2.1 branch November 26, 2019 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@july2993 july2993 july2993 approved these changes

Assignees
No one assigned
Labels
status/LGT2 type/cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suzaku @IANTHEREAL @july2993