*: fix table namespace classifier. #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
disksing
commented
Oct 19, 2017
disksing
commented
- GetAllNamespaces should contain DefaultNamespace, or the stores in default namespace will not be balanced.
- _ IsPureTableID_ need decode the key before check if it is table prefix.
nolouch
reviewed
Oct 19, 2017
table/codec.go
Outdated
| @@ -84,7 +84,11 @@ func decodeCmpUintToInt(u uint64) int64 { | |||
|
|
|||
| // IsPureTableID return true iff b is consist of tablePrefix and 8-byte tableID | |||
siddontang
reviewed
Oct 19, 2017
| @@ -82,9 +82,13 @@ func decodeCmpUintToInt(u uint64) int64 { | |||
| return int64(u ^ signMask) | |||
| } | |||
|
|
|||
| // IsPureTableID return true iff b is consist of tablePrefix and 8-byte tableID | |||
| // IsPureTableID returns true if b is consist of tablePrefix and 8-byte tableID | |||
| func IsPureTableID(b []byte) bool { | |||
siddontang
reviewed
Oct 19, 2017
| @@ -123,6 +123,7 @@ func (c *tableNamespaceClassifier) GetAllNamespaces() []string { | |||
| for name := range c.nsInfo.namespaces { | |||
| nsList = append(nsList, name) | |||
| } | |||
| nsList = append(nsList, namespace.DefaultNamespace) | |||
There was a problem hiding this comment.
need to check duplicated default here?
There was a problem hiding this comment.
Maybe forbid creating namespace using global instead.
Closed
|
LGTM |
nolouch
approved these changes
Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.