balance hot regions by peer && by leader #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddontang
reviewed
May 10, 2017
server/balancer.go
Outdated
| RegionsCountAsLeader int `json:"regions_count_as_leader"` | ||
| RegionsStatAsLeader RegionsStat | ||
|
|
||
| // Hot regions in this store as the role of Follower or Follower |
There was a problem hiding this comment.
what is of Follower or Follower?
disksing
reviewed
May 15, 2017
server/balancer.go
Outdated
| // Hot regions in this store as the role of replica | ||
| WrittenBytesAsPeer uint64 `json:"total_written_bytes_as_peer"` | ||
| RegionsCountAsPeer int `json:"regions_count_as_peer"` | ||
| RegionsStatAsPeer RegionsStat `json:"statistics_as_peer"` |
There was a problem hiding this comment.
I think you can use 2 maps to store 2 types of hot regions.
server/balancer.go
Outdated
| if !ok { | ||
| status = &StoreHotRegions{ | ||
| RegionsStat: make(RegionsStat, 0, storeHotRegionsDefaultLen), | ||
| LeaderStoreID := regionInfo.Leader.GetStoreId() |
There was a problem hiding this comment.
LeaderStoreID -> leaderStoreID
server/balancer.go
Outdated
| status = &StoreHotRegions{ | ||
| RegionsStat: make(RegionsStat, 0, storeHotRegionsDefaultLen), | ||
| LeaderStoreID := regionInfo.Leader.GetStoreId() | ||
| StoreIDs := regionInfo.GetStoreIds() |
nolouch
reviewed
May 16, 2017
server/balancer.go
Outdated
| minRegionsCount := int(math.MaxInt32) | ||
| for _, storeID := range candidateStoreIDs { | ||
| if s, ok := h.scoreStatus[storeID]; ok { | ||
| if srcHotRegionsCount-s.RegionsStatAsPeer.Len() > 1 && minRegionsCount > s.RegionsStatAsLeader.Len() { |
There was a problem hiding this comment.
s/RegionsStatAsLeader/RegionsStatAsPeer
server/balancer.go
Outdated
| } | ||
|
|
||
| avgRegionCount := hotRegionTotalCount / float64(len(h.scoreStatus)) | ||
| // Multiplied by hotRegionLimitFactor to avoid transfer back and forth | ||
| limit := uint64((float64(s.RegionsStat.Len()) - avgRegionCount) * hotRegionLimitFactor) | ||
| limit := uint64((float64(s.RegionsStatAsPeer.Len()) - avgRegionCount) * hotRegionLimitFactor) |
There was a problem hiding this comment.
need we adjust limit by leader?
siddontang
reviewed
May 20, 2017
server/balancer.go
Outdated
| func (h *balanceHotRegionScheduler) GetStatus() *StoreHotRegionInfos { | ||
| h.RLock() | ||
| defer h.RUnlock() | ||
| asPeer := make(map[uint64]*HotRegionsStat) |
disksing
reviewed
May 22, 2017
server/balancer.go
Outdated
| } | ||
|
|
||
| func newBalanceHotRegionScheduler(opt *scheduleOption) *balanceHotRegionScheduler { | ||
| return &balanceHotRegionScheduler{ | ||
| opt: opt, | ||
| limit: 1, | ||
| scoreStatus: make(map[uint64]*StoreHotRegions), | ||
| statisticsAsPeer: make(map[uint64]*HotRegionsStat), | ||
| statisticsAsLeader: make(map[uint64]*HotRegionsStat), |
There was a problem hiding this comment.
Seems not well formatted? Have you tried make dev?
server/balancer.go
Outdated
|
|
||
| if srcPeer == nil { | ||
| // Todo: should panic here | ||
| return nil, nil, nil |
There was a problem hiding this comment.
Why should panic here? Is there a chance that the hot region statistics and region cache are not perfectly synced?
server/balancer.go
Outdated
| sourceStore = sid | ||
| if maxHotStoreRegionCount == statistics.RegionsStat.Len() && maxWrittenBytes < statistics.WrittenBytes { | ||
| maxWrittenBytes = statistics.WrittenBytes | ||
| srcStoreID = storeID |
There was a problem hiding this comment.
I suppose you can make it simpler:
count, writtenBytes := statistics.RegionStat.Len(), statistics.WrittenBytes
if count >= 2 && (count > maxRegionCount || count == maxRegionCount && writtenBytes > maxWrittenBytes) {
maxRegionCount, maxWrittenBytes = count, writtenBytes
srcStoreID = storeID
}
nolouch
reviewed
May 22, 2017
server/balancer.go
Outdated
| destStoreID = h.selectDestStoreByPeer(destStoreIDs, srcRegion, srcStoreID) | ||
| if destStoreID != 0 { | ||
| srcRegion.WrittenBytes = rs.WrittenBytes | ||
| h.adjustBalanceLimitByPeer(srcStoreID) |
There was a problem hiding this comment.
If the peer is relatively balanced, the limit will not adjust when balance leader.
|
Any update? |
|
@nolouch PTAL |
nolouch
reviewed
May 25, 2017
server/balancer.go
Outdated
| @@ -31,6 +30,13 @@ const ( | |||
| bootstrapBalanceDiff = 2 | |||
| ) | |||
|
|
|||
| type BalanceType int | |||
There was a problem hiding this comment.
please fix this remind by make dev. and then pass the ci
@zhangjinpeng1987 Please merge master and fix the compile error. |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just consider the leader when do "hot regions" balance, this will lead to a bad situation that a store contains many hot regions’ peer, and TiKV nodes load various from each other.
@nolouch @disksing @siddontang PTAL