*: show more region info in api #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the conflict first. |
disksing
reviewed
Mar 29, 2017
pdctl/command/region_command.go
Outdated
| return | ||
| } | ||
| region, leader, err := client.GetRegion(context.Background(), key) | ||
| prefix := fmt.Sprintf(regionKeyPrefix, key) |
There was a problem hiding this comment.
Any needs of using url.PathEscape()?
There was a problem hiding this comment.
the function PathEscape is new add in go 1.8. It is enough to deal with the key firstly with the protobuf format.
siddontang
reviewed
Mar 29, 2017
pdctl/command/region_command.go
Outdated
| regionPrefix = "pd/api/v1/region/%s" | ||
| regionsPrefix = "pd/api/v1/regions" | ||
| regionIDPrefix = "pd/api/v1/region/id/%s" | ||
| regionKeyPrefix = "pd/api/v1/region/key/%s" |
There was a problem hiding this comment.
prefix should not contain %s here, you can format whole key explicitly.
There was a problem hiding this comment.
or use string add directly
siddontang
reviewed
Mar 29, 2017
server/cluster.go
Outdated
| // GetRegionInfoByKey gets regionInfo by region key from cluster. | ||
| func (c *RaftCluster) GetRegionInfoByKey(regionKey []byte) *RegionInfo { | ||
| region := c.cachedCluster.searchRegion(regionKey) | ||
| if region == nil { |
There was a problem hiding this comment.
you can return region here directly, no need checking nil here
siddontang
reviewed
Mar 29, 2017
server/cluster.go
Outdated
| // GetRegionInfoByID gets regionInfo by regionID from cluster. | ||
| func (c *RaftCluster) GetRegionInfoByID(regionID uint64) *RegionInfo { | ||
| region := c.cachedCluster.getRegion(regionID) | ||
| if region == nil { |
|
what does the pd-ctl output now? |
|
like |
|
I think we should support protobuf string output format for start and end key later. LGTM |
|
LGTM |
siddontang
approved these changes
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #583
PTAL @disksing @siddontang @andelf