Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug that PD might panic if there is down store with 10 minutes #3069

Merged
merged 4 commits into from
Oct 14, 2020

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Oct 13, 2020

What problem does this PR solve?

Fix the bug that PD might panic if there is down store with 10 minutes
#3053

What is changed and how it works?

replace healthy filter with Connected filter

Check List

Tests

  • Unit test

Release note

  • Fix the bug that PD might panic if there is down store with 10 minutes

@lhy1024 lhy1024 added the component/scheduler Scheduler logic. label Oct 13, 2020
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 13, 2020
@nolouch
Copy link
Contributor

nolouch commented Oct 14, 2020

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 14, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 14, 2020
@lhy1024 lhy1024 added this to the v4.0.8 milestone Oct 14, 2020
@HunDunDM
Copy link
Member

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 14, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 6e87902 into tikv:release-4.0 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/scheduler Scheduler logic. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants