Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(label): tolerate backslash in the label name (#1595) #2083

Merged
merged 2 commits into from
Jan 7, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jan 7, 2020

cherry-pick #1595 to release-3.0


Signed-off-by: Shafreeck Sea [email protected]

Closes #1588

What problem does this PR solve?

tolerate backslash in the label name.

What is changed and how it works?

relax the rules to check the validation of a label.

Check List

Tests

  • Unit test

@sre-bot sre-bot added component/schedule Scheduling logic. cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels Jan 7, 2020
@sre-bot sre-bot requested review from disksing and nolouch January 7, 2020 11:33
@codecov-io
Copy link

Codecov Report

Merging #2083 into release-3.0 will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.0    #2083      +/-   ##
===============================================
+ Coverage        69.57%   69.61%   +0.03%     
===============================================
  Files              170      170              
  Lines            16802    16802              
===============================================
+ Hits             11690    11696       +6     
+ Misses            4141     4139       -2     
+ Partials           971      967       -4
Impacted Files Coverage Δ
server/util.go 75.15% <ø> (+2.54%) ⬆️
server/schedulers/random_merge.go 62.5% <0%> (-5%) ⬇️
server/leader.go 78.77% <0%> (-0.82%) ⬇️
server/cluster.go 81.72% <0%> (-0.51%) ⬇️
server/handler.go 51.37% <0%> (-0.51%) ⬇️
server/grpc_service.go 59.91% <0%> (-0.22%) ⬇️
client/client.go 74.73% <0%> (ø) ⬆️
server/region_syncer/client.go 85.52% <0%> (+3.94%) ⬆️
server/tso.go 80.85% <0%> (+4.25%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 330c108...0ee65f8. Read the comment docs.

@lhy1024
Copy link
Contributor

lhy1024 commented Jan 7, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 7, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 7, 2020

/run-all-tests

@sre-bot sre-bot merged commit 488afe4 into tikv:release-3.0 Jan 7, 2020
@lhy1024 lhy1024 modified the milestone: v3.0.9 Jan 7, 2020
@nolouch nolouch modified the milestones: v3.0.10, v3.0.9 Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/schedule Scheduling logic. status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants