parser: fix aggregate functions compatibility to MySQL8.0 #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- std - stddev - stddev_pop - stddev_samp - var_pop - var_samp - variance
|
|
kennytm
reviewed
Dec 9, 2020
| @@ -1,19 +1,26 @@ | |||
| module github.com/pingcap/parser | |||
|
|
|||
| require ( | |||
| github.com/cznic/fileutil v0.0.0-20181122101858-4d67cfea8c87 // indirect | |||
There was a problem hiding this comment.
i don't think you need to modify go.mod and go.sum.
| @@ -3243,6 +3243,48 @@ func (s *testParserSuite) TestErrorMsg(c *C) { | |||
|
|
|||
| _, _, err = parser.Parse("select 1 collate some_unknown_collation", "", "") | |||
| c.Assert(err.Error(), Equals, "[ddl:1273]Unknown collation: 'some_unknown_collation'") | |||
|
|
|||
| _, _, err = parser.Parse("select std(all c1) from t", "", "") | |||
There was a problem hiding this comment.
if you're truly aiming for MySQL 8.0 compatibility then all must still be supported.
mysql> select version();
+-----------+
| version() |
+-----------+
| 8.0.20 |
+-----------+
1 row in set (0.00 sec)
mysql> select std(all a) from a;
+------------+
| std(all a) |
+------------+
| 0.5 |
+------------+
1 row in set (0.00 sec)
mysql> select std(distinct a) from a;
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'distinct a) from a' at line 1
|
I think it should close for now, if it is necessary for related issue, we just let it re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #1116
What is changed and how it works?
change yacc rules of
SumExprbelow :Check List
Tests
Code changes
Side effects
Related changes