Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsdb: update vm to v1.76.1; expose more params (#213) #253

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #213

What problem does this PR solve?

Issue Number: close #212

What is changed and how it works?

  • Expose -search.maxUniqueTimeseries to users. This is done by adding a new item to the configuration file.
  • Also add -retentionPeriod to the configuration file. (Note: cmdline arg take precedence over configuration file.)
  • Upgrade vm to v1.76.1 for -search.maxUniqueTimeseries to take effect.

Example:

# config.toml
# ...

[tsdb]
# Data with timestamps outside the retentionPeriod is automatically deleted
# The following optional suffixes are supported: h (hour), d (day), w (week), y (year).
# If suffix isn't set, then the duration is counted in months.
retention-period = "1"
# `search-max-unique-timeseries` limits the number of unique time series a single query can find and process.
# VictoriaMetrics(tsdb) keeps in memory some metainformation about the time series located by each query
# and spends some CPU time for processing the found time series. This means that the maximum memory usage
# and CPU usage a single query can use is proportional to `search-max-unique-timeseries`.
search-max-unique-timeseries = 300000

Signed-off-by: mornyx <[email protected]>
@mornyx
Copy link
Collaborator

mornyx commented Jul 25, 2024

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 25, 2024
Copy link

ti-chi-bot bot commented Jul 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mornyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jul 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-25 05:47:01.132653549 +0000 UTC m=+1110443.123595016: ☑️ agreed by mornyx.

@ti-chi-bot ti-chi-bot bot added the approved label Jul 25, 2024
@mornyx
Copy link
Collaborator

mornyx commented Jul 25, 2024

/merge

Copy link

ti-chi-bot bot commented Jul 25, 2024

@mornyx: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit c0cf08c into pingcap:release-7.5 Jul 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants