-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monitoring: support to change file persistence #13
Conversation
Signed-off-by: qiffang <[email protected]>
The datasource files are json format, but the filename suffix is |
|
Oh, tidb-operator uses json format but mount it as yaml file. That way I think we should fix it in tidb-operator, and keep this consistent with tidb-operator. |
I will also update |
Using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: qiffang [email protected]
Function
Update logic:
Init shell copy rule files to $PROM_PATH/rules and then copy and overwrite files in $PERSISTENT_PATH/$TIDB_VERSION to $PROM_PATH/rules
Reload receive 2 new arguments: root store path (Persistent path) and sub store path(TIDB Version)
Reload will create/overwrite updated files to $PERSISTENT_PATH/$TIDB_VERSION
Test