Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring: support to change file persistence #13

Merged
merged 3 commits into from
Sep 25, 2019

Conversation

qiffang
Copy link
Contributor

@qiffang qiffang commented Sep 10, 2019

Signed-off-by: qiffang [email protected]
Function
Update logic:

  • Init shell copy rule files to $PROM_PATH/rules and then copy and overwrite files in $PERSISTENT_PATH/$TIDB_VERSION to $PROM_PATH/rules

  • Reload receive 2 new arguments: root store path (Persistent path) and sub store path(TIDB Version)

  • Reload will create/overwrite updated files to $PERSISTENT_PATH/$TIDB_VERSION

Test

  • Upgrade values and keep the TIDB version, the changed files is persistent
  • Upgrade TIDB Version, updated rules is loss

cmd/init.sh Outdated Show resolved Hide resolved
@tennix
Copy link
Member

tennix commented Sep 23, 2019

The datasource files are json format, but the filename suffix is .yaml. This is confusing.

@qiffang
Copy link
Contributor Author

qiffang commented Sep 23, 2019

The datasource files are json format, but the filename suffix is .yaml. This is confusing.

json postfix is invalid. And the file is from tidb-operator, do you think we need to update files to yaml format?

@tennix
Copy link
Member

tennix commented Sep 23, 2019

Oh, tidb-operator uses json format but mount it as yaml file. That way I think we should fix it in tidb-operator, and keep this consistent with tidb-operator.

@qiffang
Copy link
Contributor Author

qiffang commented Sep 23, 2019

Oh, tidb-operator uses json format but mount it as yaml file. That way I think we should fix it in tidb-operator, and keep this consistent with tidb-operator.

I will also update yaml format for these files in this PR.

@qiffang
Copy link
Contributor Author

qiffang commented Sep 23, 2019

Oh, tidb-operator uses json format but mount it as yaml file. That way I think we should fix it in tidb-operator, and keep this consistent with tidb-operator.

Using yaml format to replace json format

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiffang qiffang merged commit be843a5 into master Sep 25, 2019
@wuhuizuo wuhuizuo deleted the persistent-update-rules branch January 23, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants