Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove grpc-rs dep? #403

Open
nrc opened this issue May 22, 2019 · 3 comments
Open

Remove grpc-rs dep? #403

nrc opened this issue May 22, 2019 · 3 comments

Comments

@nrc
Copy link
Contributor

nrc commented May 22, 2019

We depend on grpc-rs which causes a big dent in our compile time, in particular due to grpc-sys. However, the only reason we depend on grpc-rs is for some high-level types. With a bit of refactoring, we could move those into a separate crate (grpc-types) and greatly reduce our compile time.
@siddontang
Copy link
Member

Great!!!

@gregwebs
Copy link
Contributor

@nrc is this issue still relevant?

@nrc
Copy link
Contributor Author

nrc commented Jan 21, 2021

Yeah, I think so, though not very high priorty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gregwebs @nrc @siddontang