Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

dumpling/gcs: fix http client credential problem #395

Merged

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Nov 23, 2021

What problem does this PR solve?

cherry-pick of pingcap/tidb#29414

What is changed and how it works?

Dumpling will fail to export data to GCS because of a lack of privileges when we set our own HTTP client without specifying transport tls. This PR deletes it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Test dump data with dumpling before/after this commit. Before this commit GCS will return a gcs error "google api: Error 401: anonymous caller does not have storage.object.create access to the Google Cloud Storage object.". After this commit dumpling can successfully dump data to GCS.

Related changes

  • Need to cherry-pick to the release branch

Release note

  • fix gcs http client credential problem

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@lichunzhu
Copy link
Contributor Author

/cherry-pick release-5.2

@ti-chi-bot
Copy link
Member

@lichunzhu: once the present PR merges, I will cherry-pick it on top of release-5.2 in the new PR and assign it to you.

In response to this:

/cherry-pick release-5.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lichunzhu
Copy link
Contributor Author

/cherry-pick release-5.0

@ti-chi-bot
Copy link
Member

@lichunzhu: once the present PR merges, I will cherry-pick it on top of release-5.0 in the new PR and assign it to you.

In response to this:

/cherry-pick release-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lichunzhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6bcd777

@ti-chi-bot ti-chi-bot merged commit 1fd9ecb into pingcap:release-5.1 Nov 23, 2021
@lichunzhu lichunzhu deleted the release-5.1-createExternalStorage branch November 23, 2021 14:56
ti-chi-bot pushed a commit to ti-chi-bot/dumpling that referenced this pull request Nov 23, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #396.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #397.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants