-
Notifications
You must be signed in to change notification settings - Fork 85
dumpling/gcs: fix http client credential problem #395
dumpling/gcs: fix http client credential problem #395
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cherry-pick release-5.2 |
@lichunzhu: once the present PR merges, I will cherry-pick it on top of release-5.2 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/cherry-pick release-5.0 |
@lichunzhu: once the present PR merges, I will cherry-pick it on top of release-5.0 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6bcd777
|
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #396. |
In response to a cherrypick label: new pull request created: #397. |
What problem does this PR solve?
cherry-pick of pingcap/tidb#29414
What is changed and how it works?
Dumpling will fail to export data to GCS because of a lack of privileges when we set our own HTTP client without specifying transport tls. This PR deletes it.
Check List
Tests
Test dump data with dumpling before/after this commit. Before this commit GCS will return a gcs error "google api: Error 401: anonymous caller does not have storage.object.create access to the Google Cloud Storage object.". After this commit dumpling can successfully dump data to GCS.
Related changes
Release note