Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd-ctl: update the usage of region key #694

Merged
merged 2 commits into from
Oct 29, 2018

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Oct 29, 2018

This PR is based on tikv/pd#1298.

@rleungx rleungx requested review from lilin90 and disksing October 29, 2018 03:01
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM


Use this command to query the region that a specific key resides in. It supports the raw and protobuf formats.
Use this command to query the region that a specific key resides in. It supports the raw and encoding formats. And it needs to use single quotes around the key when it is in the encoding format.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it needs to use -> you need to use

@disksing
Copy link
Contributor

LGTM.

@disksing disksing merged commit 65078f9 into pingcap:master Oct 29, 2018
QueenyJin pushed a commit that referenced this pull request Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants