-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add descriptions of new panels and update the plan cache doc #11110
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @fzzf678 |
@TomShawn: GitHub didn't allow me to request PR reviews from the following users: fzzf678. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: xixirangrang <[email protected]>
system-variables.md
Outdated
- Scope: SESSION | GLOBAL | ||
- Persists to cluster: Yes | ||
- Default value: `ON` | ||
- This variable controls whether to count the memory consumed by the execution plans cached in the Prepared Plan Cache. When this switch is disabled, the memory usage displayed on the **Plan Cache Memory Usage** monitoring panel is 0. For details, see [Memory management of Prepared Plan Cache](/sql-prepared-plan-cache.md#memory-management-of-prepared-plan-cache). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This variable controls whether to count the memory consumed by the execution plans cached in the Prepared Plan Cache. When this switch is disabled, the memory usage displayed on the **Plan Cache Memory Usage** monitoring panel is 0. For details, see [Memory management of Prepared Plan Cache](/sql-prepared-plan-cache.md#memory-management-of-prepared-plan-cache). | |
- This variable controls whether to count the memory consumed by the execution plans cached in the Prepared Plan Cache. For details, see [Memory management of Prepared Plan Cache](/sql-prepared-plan-cache.md#memory-management-of-prepared-plan-cache). |
Co-authored-by: fzzf678 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: fzzf678 <[email protected]>
/remove-status LGT1 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 16dbc16
|
What is changed, added or deleted? (Required)
Add descriptions of new panels and update the plan cache doc
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?