Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions of new panels and update the plan cache doc #11110

Merged
merged 7 commits into from
Nov 7, 2022

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Nov 1, 2022

What is changed, added or deleted? (Required)

Add descriptions of new panels and update the plan cache doc

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 1, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@TomShawn TomShawn self-assigned this Nov 1, 2022
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 1, 2022
@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. v6.4 This PR/issue applies to TiDB v6.4. and removed missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 1, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Nov 1, 2022

/cc @fzzf678

@ti-chi-bot
Copy link
Member

@TomShawn: GitHub didn't allow me to request PR reviews from the following users: fzzf678.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @fzzf678

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TomShawn TomShawn removed the request for review from shichun-0415 November 1, 2022 05:55
@hfxsd hfxsd self-requested a review November 1, 2022 07:03
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 2, 2022
@TomShawn TomShawn added for-future-release This PR only applies to master for now and might cherry-pick to a future release. v6.4 This PR/issue applies to TiDB v6.4. and removed v6.4 This PR/issue applies to TiDB v6.4. for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Nov 2, 2022
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 3, 2022
- Scope: SESSION | GLOBAL
- Persists to cluster: Yes
- Default value: `ON`
- This variable controls whether to count the memory consumed by the execution plans cached in the Prepared Plan Cache. When this switch is disabled, the memory usage displayed on the **Plan Cache Memory Usage** monitoring panel is 0. For details, see [Memory management of Prepared Plan Cache](/sql-prepared-plan-cache.md#memory-management-of-prepared-plan-cache).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- This variable controls whether to count the memory consumed by the execution plans cached in the Prepared Plan Cache. When this switch is disabled, the memory usage displayed on the **Plan Cache Memory Usage** monitoring panel is 0. For details, see [Memory management of Prepared Plan Cache](/sql-prepared-plan-cache.md#memory-management-of-prepared-plan-cache).
- This variable controls whether to count the memory consumed by the execution plans cached in the Prepared Plan Cache. For details, see [Memory management of Prepared Plan Cache](/sql-prepared-plan-cache.md#memory-management-of-prepared-plan-cache).

system-variables.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 3, 2022
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor Author

TomShawn commented Nov 7, 2022

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 7, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Nov 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 16dbc16

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2022
@ti-chi-bot ti-chi-bot merged commit 3ac5a29 into pingcap:master Nov 7, 2022
@TomShawn TomShawn deleted the grafana-plancache branch November 7, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.4 This PR/issue applies to TiDB v6.4.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants